Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334572 - [LTTng] LTTng "Delete Trace" menu option in Experiment context is misleading
Summary: [LTTng] LTTng "Delete Trace" menu option in Experiment context is misleading
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Francois Chouinard CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 291077
  Show dependency tree
 
Reported: 2011-01-17 14:23 EST by Daniel U. Thibault CLA
Modified: 2022-01-13 14:52 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel U. Thibault CLA 2011-01-17 14:23:43 EST
Build Identifier: 20100917-0705

"Deletion" in an Eclipse context entails removal from the workspace, often with the option of simultaneous removal from the file system (true deletion). As the menu option in question does not remove its target from the workspace, it is mislabeled and thus misleading.

Reproducible: Always

Steps to Reproduce:
1. Launch Eclipse
2. Open the LTTng perspective
3. Create an LTTng project ("New>Project...>LTTng>LTTng Project")
4. Import a trace ("Import Traces" from Traces folder contextual menu)
5. Create an experiment ("New Experiment" from Experiments folder contextual menu)
6. Add the trace to the experiment ("Select Traces" from new experiment folder contextual menu)
7. Invoke the contextual menu of the trace in your experiment
8. Choose "Delete Trace"
9. Observe how the "deleted" trace is still listed in the Traces folder
10. Conclude the menu option in step 8 ought to have been "Remove Trace"
Comment 1 Francois Chouinard CLA 2011-06-02 11:50:16 EDT
Good point.
Comment 2 Francois Chouinard CLA 2012-02-24 17:17:32 EST
Added a new menu item ("Remove") that is displayed only when the selected item is a TmfTraceElement and its parent is a TmfExperimentElement. In that case, the "Delete" menu item is not displayed.

Both menu items trigger the same command handler. This is a cosmetic change.

Fixed in commit 358bcba3e40351802dcdfc06914caed5d6bc3d9b.
Comment 3 Francois Chouinard CLA 2012-03-26 14:02:23 EDT
Delivered in 0.10.0