Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334556 - Need to restore support fallback to dependentObject in maintenance stream
Summary: Need to restore support fallback to dependentObject in maintenance stream
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Hari Shankar CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-17 12:59 EST by Hari Shankar CLA
Modified: 2011-01-31 11:38 EST (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
patch (1.67 KB, patch)
2011-01-17 12:59 EST, Hari Shankar CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hari Shankar CLA 2011-01-17 12:59:25 EST 
Build Identifier: 305P

As part of bug 322678 we moved the EarVirtualComponent.getHardReferences method to use archiveName instead of the dependentObject. This is causing the EAR validator to get out of sync when the user imports an older project that does not contain the archiveName set in the .component file.

This patch enhances the previous patch as follows:

1. First try to get the archiveName using referencedComponent.getArchiveName()
2. If step 1 returns null, fall back on old method (referencedComponent.getDependentObject())) to ensure backward toleration
3. If step 2 returns null compute the default archiveName.

Patch attached for review.

Reproducible: Always
Comment 1 Hari Shankar CLA 2011-01-17 12:59:49 EST 
Created attachment 186930 [details]
patch

Patch
Comment 2 Chuck Bridgham CLA 2011-01-17 13:07:15 EST 
approved
Comment 3 Carl Anderson CLA 2011-01-31 11:38:50 EST 
Committed to R3_0_5_patches