Community
Participate
Working Groups
After removing the qooxdoo logging implementation, the combo box in the lauchner is obsolete.
Created attachment 188237 [details] Version 1 Provided patch removes the qooxdoo logging functionality included into RAP-tooling. Test cases has been updated also.
Not sure from when on we can remove the log-level UI . It might be that users will use 'new' tooling to develop RAP applications based on 1.3 (where the log-leve is still working). In the meantime, we could append a text right to the combo that indicates that this setting is only applies to runtimes < 1.4 M5 Or am I too precautios, what do you think?
Of course, you're right. With bug 334913, you can even install an 1.3 runtime using the 1.4 tooling, before the release of 1.4. Would the 1.3 runtime be unusable without this option? The default log level is OFF, that means if we removed this option, the 1.3 runtime would not even render error messages, right? Whereas in the current 1.4 runtime, we changed a lot of "this.error()" occurrences to "throw new Error()" - is this correct, Tim? If so, should we then retain the option for 1.4?
Created attachment 188679 [details] Version 2 >If so, should we then retain the option for 1.4? The decision was to retain the option for 1.4. The provided patch decorates the log level combo box with a warning which informs the user that log level is not supported in RAP 14.
I like this approach a lot. I modified your patch a little (formating and naming) and committed it to CVS HEAD. Good job!
