Community
Participate
Working Groups
Text fields in the cell editors don't have a border. This is OK when the celleditor appears in a table (with NatTable for example), but this looks ugly in a dialog. I found a partial workaround by adding another Composite with SWT.BORDER around the cell editor Composite, but this doesn't look native. I think a better solution would be to add a boolean on the constructor of each cell editor that uses a Text field to determine whether it should display a border on its text field.
Created attachment 188774 [details] Add style to the TextField of cell editor composite Hi, Here is a patch that give the user the possibility to call the composite with a "style" parameter. A constructor has been added to AbstractCellEditorComposite class and changes has been repercuted on org.eclipse.emf.facet.widgets.celleditors and org.eclipse.emf.facet.widgets.celleditors.ecore plug-ins (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards, Nicolas Guyomar
Comment on attachment 188774 [details] Add style to the TextField of cell editor composite This is a contribution from an employee of Mia-Software, targeting a future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (cf bug 322327).
I committed the patch in revision 288.
Nicolas B., I’m not able to close this bug because there isn’t any screenshot of the problem and I do not remember the problem: I cannot then check the difference. If you remember the problem, please, can you check the fix and closed this bug? Regards, Gregoire
It works now: I'm closing this bug.