Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334546 - [celleditors] no border on Text field
Summary: [celleditors] no border on Text field
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-17 11:57 EST by Nicolas Bros CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
nicolas.bros: indigo+


Attachments
Add style to the TextField of cell editor composite (38.23 KB, patch)
2011-02-11 08:56 EST, Nicolas Guyomar CLA
nicolas.bros: iplog+
nicolas.bros: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-01-17 11:57:54 EST
Text fields in the cell editors don't have a border.
This is OK when the celleditor appears in a table (with NatTable for example), but this looks ugly in a dialog.

I found a partial workaround by adding another Composite with SWT.BORDER around the cell editor Composite, but this doesn't look native.

I think a better solution would be to add a boolean on the constructor of each cell editor that uses a Text field to determine whether it should display a border on its text field.
Comment 1 Nicolas Guyomar CLA 2011-02-11 08:56:31 EST
Created attachment 188774 [details]
Add style to the TextField of cell editor composite

Hi,

Here is a patch that give the user the possibility to call the composite with a "style" parameter.
A constructor has been added to AbstractCellEditorComposite class and changes has been repercuted on 
org.eclipse.emf.facet.widgets.celleditors and org.eclipse.emf.facet.widgets.celleditors.ecore plug-ins


(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards,
Nicolas Guyomar
Comment 2 Nicolas Bros CLA 2011-02-11 09:28:06 EST
Comment on attachment 188774 [details]
Add style to the TextField of cell editor composite

This is a contribution from an employee of Mia-Software, targeting a future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (cf bug 322327).
Comment 3 Nicolas Bros CLA 2011-02-11 09:29:56 EST
I committed the patch in revision 288.
Comment 4 Gregoire Dupe CLA 2011-06-08 10:59:29 EDT
Nicolas B.,

I’m not able to close this bug because there isn’t any screenshot of the problem and I do not remember the problem: I cannot then check the difference.

If you remember the problem, please, can you check the fix and closed this bug?

Regards,
Gregoire
Comment 5 Nicolas Bros CLA 2012-05-23 08:40:04 EDT
It works now: I'm closing this bug.