334520 – [api] provide method to generate commit message for a task

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 334520 - [api] provide method to generate commit message for a task

Summary: [api] provide method to generate commit message for a task

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	PC Linux

Importance:	P3 enhancement (vote)
Target Milestone:	3.5
Assignee:	Steffen Pingel
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-01-17 10:35 EST by Benjamin Muskalla
Modified:	2011-01-24 15:13 EST (History)
CC List:	3 users (show)

See Also:

Attachments
proposed change (9.45 KB, patch) 2011-01-22 21:36 EST, Steffen Pingel	no flags	Details \| Diff
mylyn/context/zip (18.36 KB, application/octet-stream) 2011-01-22 21:36 EST, Steffen Pingel	no flags	Details
updated patch (4.30 KB, patch) 2011-01-24 15:10 EST, Steffen Pingel	no flags	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Benjamin Muskalla

2011-01-17 10:35:10 EST

We should provide API to access the functionality of ContextChangeSet#getComment(boolean checkTaskRepository, ITask task, IResource[] resources) in order to fill in the commit message for SCM providers.

Comment 1 Steffen Pingel

2011-01-18 02:49:27 EST

+1 The Versions project should not depend on Tasks though so we would need to figure out where to put this. Would it work to make this API available in Mylyn Tasks for now?

Comment 2 Benjamin Muskalla

2011-01-18 05:10:01 EST

Yep, that should work. As Mylyn is fully backward compatible, I don't see a reason not to use the new API right now.

Comment 3 Steffen Pingel

2011-01-22 21:36:28 EST

Created attachment 187373 [details]
proposed change

Comment 4 Steffen Pingel

2011-01-22 21:36:30 EST

Created attachment 187374 [details]
mylyn/context/zip

Comment 5 Steffen Pingel

2011-01-22 21:37:06 EST

Can you take a look at the proposed change and let me know if the propsed API would work for EGit?

Comment 6 Benjamin Muskalla

2011-01-23 07:05:31 EST

From what I see, this would be sufficient. One minor thing I saw is that checkTaskRepository is not explained in the javadoc.

Comment 7 Steffen Pingel

2011-01-24 15:10:56 EST

Created attachment 187465 [details]
updated patch

Comment 8 Steffen Pingel

2011-01-24 15:13:55 EST

Thanks for noticing. I must have been asleep the parameter was not used and redundant. I have removed it. 

I'll post a weekly build with the changes on Wednesday.