Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334515 - [celleditors] StringMultiComposite : too high
Summary: [celleditors] StringMultiComposite : too high
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-17 09:36 EST by Nicolas Bros CLA
Modified: 2020-05-01 11:27 EDT (History)
2 users (show)

See Also:
gdupe: indigo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-01-17 09:36:12 EST
The StringMultiComposite is too high : it is set to 50 pixels high, but a single line is directly visible and editable in the field.
Comment 1 Nicolas Bros CLA 2011-01-17 09:37:17 EST
Index: src/org/eclipse/emf/facet/widgets/celleditors/ecore/composite/StringMultiComposite.java
===================================================================
--- src/org/eclipse/emf/facet/widgets/celleditors/ecore/composite/StringMultiComposite.java	(revision 125)
+++ src/org/eclipse/emf/facet/widgets/celleditors/ecore/composite/StringMultiComposite.java	(working copy)
@@ -35,7 +35,6 @@
 /** A cell editor for Strings */
 public class StringMultiComposite<T> extends AbstractCellEditorComposite<String> {
 
-	private static final int GRID_DATA_HEIGHT = 50;
 	/** the control that is used to edit the contents of the cell */
 	private final Button button;
 	private Text text = null;
@@ -56,11 +55,10 @@
 		setLayout(gd);
 
 		this.text = new Text(this, SWT.NONE);
-		this.text.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
+		this.text.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, false));
 		this.button = new Button(this, SWT.PUSH);
 		this.button.setText("..."); //$NON-NLS-1$
 		GridData data = new GridData(SWT.FILL, SWT.FILL, false, true);
-		data.heightHint = StringMultiComposite.GRID_DATA_HEIGHT;
 		this.button.setLayoutData(data);
 
 		if (originalValue != null) {
Comment 2 Nicolas Bros CLA 2011-01-17 09:38:52 EST
Fixed in revision 207 (and tested in NatTable : appearance stays the same).
Comment 3 Gregoire Dupe CLA 2011-06-08 10:04:09 EDT
This bug can be closed.