Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334477 - allow submitting of reviews from task editor
Summary: allow submitting of reviews from task editor
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 0.7   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 333945
  Show dependency tree
 
Reported: 2011-01-16 05:22 EST by Steffen Pingel CLA
Modified: 2011-02-21 15:05 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-01-16 05:22:11 EST 
Support a basic commit operation for posting of a comment and voting (code review and verification).
Comment 1 Steffen Pingel CLA 2011-02-14 01:23:16 EST 
I have made some progress on this but haven't pushed by changes. The basic idea is to encode required Gerrit data objects as JSon streams in Task Data. That avoids a lot of marshaling for Gerrit specific data and provides a nice Java API for modifying Gerrit objects.
Comment 2 Steffen Pingel CLA 2011-02-21 05:34:24 EST 
Added support for abandoning, restoring, submitting and publishing of reviews from the task editor. For the initial release all operations are performed online against the repository through modal dialogs to simplify the implementation. We can consider offline support for a future iteration.