Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334438 - Disable the Cancel button in Project Facets dialog
Summary: Disable the Cancel button in Project Facets dialog
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard: Usability
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 17:36 EST by Roberto Sanchez Herrera CLA
Modified: 2011-01-19 14:56 EST (History)
1 user (show)

See Also:

Attachments
Disable Cancel button (1.72 KB, patch)
2011-01-14 17:42 EST, Roberto Sanchez Herrera CLA 		konstantin: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2011-01-14 17:36:29 EST 
Build Identifier: WTP M-3.2.3-20110113194837

The Cancel button in the Project Facets dialog does not revert changes when pressed, so the result is the same as if OK is pressed. This behavior is misleading, so disabling the Cancel button is proposed.

More details can be found here: 
http://www.eclipse.org/forums/index.php?t=rview&goto=639262#msg_639262

Reproducible: Always

Steps to Reproduce:
1.Open any new project wizard (new dynamic web project, EJB project, etc.)
2.Click on Modify...
3.Select any facet
4.Click Cancel. 
5.Click on Modify... again. The facet you selected in step 3 is still selected.
Comment 1 Roberto Sanchez Herrera CLA 2011-01-14 17:42:47 EST 
Created attachment 186857 [details]
Disable Cancel button
Comment 2 Konstantin Komissarchik CLA 2011-01-19 13:09:34 EST 
Thanks for your contribution. I have released the patch into 3.3 M5 stream.
Comment 3 Carl Anderson CLA 2011-01-19 14:53:03 EST 
Konstantin, is there a chance that we could get this into WTP 3.2.3?  I know it would require PMC approval, since it is a UI/"behavior" change (but really isn't, since Cancel doesn't cancel), but I also see it as a much needed usability improvement.
Comment 4 Konstantin Komissarchik CLA 2011-01-19 14:56:04 EST 
Doesn't seem like a big deal to me, but if you think it makes sense to put this in 3.2.3, I don't have any objections either. Feel free to raise for approval. If approved, I will do the backport.