Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334397 - Backport: [jar exporter] Cannot export JAR to a project folder of a project outside the workspace
Summary: Backport: [jar exporter] Cannot export JAR to a project folder of a project o...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.4.2+   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 239695
Blocks:
  Show dependency tree
 
Reported: 2011-01-14 12:15 EST by Szymon Ptaszkiewicz CLA
Modified: 2011-01-18 03:27 EST (History)
3 users (show)

See Also:
daniel_megert: review+

Attachments
patch for R3_4_maintenance (2.33 KB, patch)
2011-01-17 10:51 EST, Markus Keller CLA 		daniel_megert: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2011-01-14 12:15:20 EST 
This bug is to cover the backport of the fix for bug 239695 to 3.4.2+. Possibly together with a fix for related bug 281867.
Comment 1 Markus Keller CLA 2011-01-17 10:51:07 EST 
Created attachment 186916 [details]
patch for R3_4_maintenance

The fix is the same implementation of org.eclipse.jdt.ui.jarpackager.JarPackageData#getAbsoluteJarLocation() as in HEAD and in R3_5_2, but without the whitespace changes in the whole file.

Re-tested all scenarios from bug 239695, bug 281867, and bug 296931.

org.eclipse.jdt.ui is already at version 3.4.3, so no need to bump.
Comment 2 Markus Keller CLA 2011-01-17 10:52:07 EST 
Dani, please review (and release if you want).
Comment 3 Dani Megert CLA 2011-01-18 03:27:38 EST 
Patch is good.

Fixed committed and released to R3_4_maintenance.
Affected files:
P org.eclipse.jdt.ui, tag='r342_v20110118'
  - org.eclipse.jdt.ui.jarpackager.JarPackageData.java, rev. 1.43.2.1
P org.eclipse.releng:
  -maps/jdtui.map, rev. 1.676.2.29