Description Victor Noël 2011-01-14 10:12:43 EST

Build Identifier: 

Hello,

I was trying to use org.eclipse.xtext.scoping.impl.FilteringScope and I noticed the following code:
	public FilteringScope(IScope delegate, final EClass ...allowedTypes) {
		this.delegate = delegate;
		this.filter = new Predicate<IEObjectDescription>(){

			public boolean apply(IEObjectDescription input) {
				for (EClass eClass : allowedTypes) {
					if (eClass.isSuperTypeOf(eClass))
						return true;
				}
				return false;
			}};
	}

Shouldn't it be something like:
	public FilteringScope(IScope delegate, final EClass ...allowedTypes) {
		this.delegate = delegate;
		this.filter = new Predicate<IEObjectDescription>(){

			public boolean apply(IEObjectDescription input) {
				for (EClass eClass : allowedTypes) {
					if (eClass.isSuperTypeOf(input.getEClass()))
						return true;
				}
				return false;
			}};
	}

Thanks

Reproducible: Always