Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334379 - Implement Drop to Frame command handler
Summary: Implement Drop to Frame command handler
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Debug (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.4.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 09:23 EST by Anton Leherbauer CLA
Modified: 2013-06-05 05:54 EDT (History)
1 user (show)

See Also:

Attachments
Drop to frame command (13.05 KB, patch)
2011-01-14 09:23 EST, Anton Leherbauer CLA 		cdtdoug: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2011-01-14 09:23:37 EST 
Created attachment 186824 [details]
Drop to frame command

Attached patch adds a "Drop to frame" command handler.  The handler is enabled only for stack frames below the top frame.
The command performs as many step out operations as necessary to reach the selected stack frame.  I tried to implement this using a step count > 1, but this resulted in an error from the agent.
Comment 1 Eugene Tarassov CLA 2011-01-14 14:53:07 EST 
I have changed TCFActionStepOut to support drop to frame without repeating the action, and added canCount() call, so it will use step counts when supported by the agent. It allows to remove Repeat class in "Drop to frame" command handler that simplifies the logic and eliminates unwanted UI updates during the command execution.

I have modified the patch to use the new functionality of TCFActionStepOut.

Committed.

Thanks!
Comment 2 Anton Leherbauer CLA 2011-01-17 03:52:59 EST 
Very elegant, thank you!