Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334359 - [DB] Duplicate entries in cdo_package_infos
Summary: [DB] Duplicate entries in cdo_package_infos
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.db (show other bugs)
Version: 4.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Egidijus Vaisnora CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 04:48 EST by Egidijus Vaisnora CLA
Modified: 2011-06-23 03:41 EDT (History)
1 user (show)

See Also:
stepper: review+

Attachments
patch v1 (889 bytes, patch)
2011-01-14 05:18 EST, Egidijus Vaisnora CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Egidijus Vaisnora CLA 2011-01-14 04:48:12 EST 
Working with MySQL. I got duplicated entries for "cdo_package_infos" table (uri was duplicated). 
Seems like code omit to create PK constraint on "uri" column.
Comment 1 Egidijus Vaisnora CLA 2011-01-14 05:18:19 EST 
Created attachment 186811 [details]
patch v1

Ensure to add UNIQUE index for PK column
Comment 2 Eike Stepper CLA 2011-01-17 04:26:00 EST 
I'm sorry but our CVS->Git migration takes longer than expected and it's not yet clear that we want to keep Git. Until a final decision is taken by the team and all workflows work as expected all reviews are on hold...
Comment 3 Eike Stepper CLA 2011-01-25 08:10:18 EST 
I vaguely recall that my initial goal was to use specific SQL syntax for PK creation. It probably didn't work very well so I removed that special handling and forgot to add the if-condition in createIndex ;-(

Please go ahead.
Comment 4 Egidijus Vaisnora CLA 2011-01-25 10:12:17 EST 
committed to trunk, revision 6930
Comment 5 Eike Stepper CLA 2011-06-23 03:41:19 EDT 
Available in R20110608-1407