Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334337 - [diagram] clean separation necessary between parts and rendering
Summary: [diagram] clean separation necessary between parts and rendering
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Shenxue Zhou CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 334342
  Show dependency tree
 
Reported: 2011-01-13 20:48 EST by Konstantin Komissarchik CLA
Modified: 2021-11-19 09:22 EST (History)
0 users

See Also:

Attachments
Separate Diagram parts from Graphiti Rendering engine (92.56 KB, text/plain)
2011-01-25 18:05 EST, Shenxue Zhou CLA 		konstantin: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2011-01-13 20:48:42 EST 
UI parts classes in ui.diagram.editor package have dependencies on Graphiti. This need to be fixed. The parts hierarchy cannot have a dependency on any rendering technology. 

We need to be able to move ui.diagram.graphiti.* packages into a separate plugin and remove sapphire.ui dependency on gef and graphiti. The diagram definition classes and parts would stay in the main sapphire.ui plugin.
Comment 1 Shenxue Zhou CLA 2011-01-25 18:05:55 EST 
Created attachment 187591 [details]
Separate Diagram parts from Graphiti Rendering engine
Comment 2 Shenxue Zhou CLA 2011-01-26 13:12:10 EST 
The patch removes dependency on Graphiti from various sapphire diagram parts. The Graphiti based diagram editor now listens to model update events broadcast-ed by the diagram parts and diagram part templates and update the diagram accordingly.
Comment 3 Konstantin Komissarchik CLA 2011-01-27 03:25:30 EST 
Patch not yet committed...
Comment 4 Konstantin Komissarchik CLA 2011-01-27 03:26:03 EST 
Patch released.
Comment 5 Konstantin Komissarchik CLA 2011-06-09 16:35:08 EDT 
This can be considered verified by observing that the main sapphire.ui plugin does not depend on graphiti or gef. Closing.