Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334305 - Update to Lucene 3.X stream
Summary: Update to Lucene 3.X stream
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3.1   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-13 14:18 EST by Chris Aniszczyk CLA
Modified: 2013-10-16 06:16 EDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2011-01-13 14:18:55 EST 
I'm not sure this is the right place to file this bug, but in the Eclipse 3.X stream, we can't use the latest 3.X stream of Lucene because of breaking changes. However, if the help system gets migrated to e4... we should update to the latest version of Lucene.
Comment 1 Paul Webster CLA 2011-01-13 14:39:54 EST 
I see with the latest 3.7 (which e4/4.1 consumes) we've just moved from lucene 1.9.1 to 2.9.1

Is it that lucene 3.x has (what we would consider) a breaking API change?  And so help can only work on 3.x or <3.0 ?

PW
Comment 2 Chris Goldthorpe CLA 2011-01-13 15:13:24 EST 
The Eclipse SDK did migrate to use Lucene 2.x for Eclipse 3.7/4.1. org.eclipse.help.base is the bundle that uses Lucene and it is binary compatible with Lucene 2.x and source compatible with Lucene 1.x or Lucene 2.x. I believe that org.eclipse.help.base is incompatible with Lucene 3.x because it uses API from Lucene 1.x that was deprecated in 2.x and removed in 3.x.

If I recode to remove the deprecations we will be source compatible with Lucene 3.x but will probably lose source compatibility with 1.x. That may be the right thing to do, my concern is that any client of the luceneSearchParticipants extension point will also be using the API from Lucene that was in 1.x but not 3.x.
Comment 3 Gunnar Wagenknecht CLA 2011-01-14 02:26:17 EST 
Keep in mind that they are already working on 4.x (merge with Solr). Might be an option if there is a release prior to upgrading in e4?
Comment 4 Alexander Kurtakov CLA 2011-08-16 11:12:10 EDT 
(In reply to comment #3)
> Keep in mind that they are already working on 4.x (merge with Solr). Might be
> an option if there is a release prior to upgrading in e4?

I thought they merged the projects only, i.e. using common scm, developers permissions, bugtracking and etc. but keeping the release artifacts separate, am I wrong?
Anyway, breaking 1.x compatibility and bringing 3.x compatibility for downstreams that want/have to use 3.x sounds like the better option for 4.2. Unless Lucene 4.x will be out prior to M3 or M4 and it can be worked on after that.
Comment 5 Alexander Kurtakov CLA 2013-10-16 04:55:52 EDT 
Luna I-builds ship with Lucene 3.5.0 so we can probably close this one.
Comment 6 Lars Vogel CLA 2013-10-16 06:16:56 EDT 
Time heals all wounds ;-) Marking as fixed.

Thanks Alexander for the follow-up.