Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334194 - [MS Toolchain] Allow use of toolchain with only VS2008 installed
Summary: [MS Toolchain] Allow use of toolchain with only VS2008 installed
Status: CLOSED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows All
: P3 enhancement (vote)
Target Milestone: 8.0   Edit
Assignee: Andrew Gvozdev CLA
QA Contact: Andrew Gvozdev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 22:00 EST by Marc-André Laperle CLA
Modified: 2011-01-13 10:34 EST (History)
1 user (show)

See Also:

Attachments
MS Toolchain, VS2008 without WinSDK (2.66 KB, patch)
2011-01-12 22:00 EST, Marc-André Laperle CLA 		no flags Details | Diff
MS Toolchain, VS2008 without WinSDK (2.81 KB, patch)
2011-01-12 23:07 EST, Marc-André Laperle CLA 		angvoz.dev: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2011-01-12 22:00:03 EST 
Created attachment 186699 [details]
MS Toolchain, VS2008 without WinSDK

Right now, the variable supplier looks for the Windows 7 SDK first and aborts if it doesn't find it. This prevents the toolchain from functioning properly when VS2008 is installed without the Windows 7 SDK. It is a common case that users will have VS2008 without the Windows SDK. This patch simply adds some null checks to allow the variable supplier to complete its initialization process and gather the variables even if the SDK is not found. In the future, I would also like to provide compatibility with VS2010 and VS Express without the Windows SDK installed.
Comment 1 Andrew Gvozdev CLA 2011-01-12 23:00:10 EST 
(In reply to comment #0)
> This patch simply adds some null
> checks to allow the variable supplier to complete its initialization process and
> gather the variables even if the SDK is not found.
Wouldn't it be sensible to quit right away if neither SDK nor VC found? The patch still updates the variables even if there is nothing to update.
Comment 2 Marc-André Laperle CLA 2011-01-12 23:07:25 EST 
Created attachment 186701 [details]
MS Toolchain, VS2008 without WinSDK

Yes, thanks!
Comment 3 Andrew Gvozdev CLA 2011-01-12 23:35:37 EST 
Committed on HEAD (8.0) with cosmetic changes. Thanks for the patch. I hope it's working as I don't have VS installed, please retest with new CDT build.

I notice that I get VC toolchain in the list even if I do not have it on my system. We probably should detect existence using the same checks.
Comment 4 CDT Genie CLA 2011-01-13 00:23:03 EST 
*** cdt cvs genie on behalf of agvozdev ***
bug 334194: [MS Toolchain] Allow use of toolchain with only VS2008 installed
Patch from Marc-Andre Laperle

[*] WinEnvironmentVariableSupplier.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/windows/org.eclipse.cdt.msw.build/src/org/eclipse/cdt/msw/build/WinEnvironmentVariableSupplier.java?root=Tools_Project&r1=1.4&r2=1.5
Comment 5 Doug Schaefer CLA 2011-01-13 09:00:53 EST 
Cool. Thanks guys. Yes, we should support other combinations.
Comment 6 Marc-André Laperle CLA 2011-01-13 10:34:06 EST 
(In reply to comment #3)
> Committed on HEAD (8.0) with cosmetic changes. Thanks for the patch. I hope
> it's working as I don't have VS installed, please retest with new CDT build.

Yes, it's now working on my PC with VS2008 only, thank you!