Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334192 - [client] nav-table places search results underneath breadcrumb, fix DOM structure funkiness
Summary: [client] nav-table places search results underneath breadcrumb, fix DOM struc...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 21:57 EST by Susan McCourt CLA
Modified: 2011-09-01 11:41 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-01-12 21:57:13 EST
I'm not sure when this problem crept up, it may have been some time and I just noticed it.  You can see it in M4.

On the tree view, when you do a search in the search bar, or click on a saved favorite, the bread crumb bar and tree both get replaced with search results.  This is the intention. 

However, on the table view, the search results simply replace the tree table.  The breadcrumb bar remains.  This is not right.

While looking at this problem, there is funkiness that should be cleaned up in both navs:

- we reuse the inner tree id when placing progress or search results.  We probably need some kind of content id that remains constant and the tree would go inside that. 
- because we often blow away/replace the content, we can't rely on storing dom nodes in the explorer.  As such, I changed the glue code to pass in ids rather than dom nodes.  But we really shouldn't be replacing a *parent* node that gets passed in.  It's okay to muck with the internal guts underneath, but it seemed to me we might be blowing away or replacing a parent node which is not cool.  check into this.
Comment 1 Susan McCourt CLA 2011-02-08 19:23:36 EST
fixed.