Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334166 - Diagram location in project should not be a src folder
Summary: Diagram location in project should not be a src folder
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: Diagram Editor (show other bugs)
Version: 0.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Stefan Dimov CLA
QA Contact: Stefan Dimov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 335176
  Show dependency tree
 
Reported: 2011-01-12 16:28 EST by Shaun Smith CLA
Modified: 2011-04-16 09:17 EDT (History)
1 user (show)

See Also:

Attachments
Folder for diagrams - not in src (38.01 KB, patch)
2011-01-24 06:46 EST, Stefan Dimov CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun Smith CLA 2011-01-12 16:28:39 EST 
When a diagram is created it is automatically put into the diagrams folder in the first src folder.  Diagrams should not be stored in src as resources in src are copied into the output folder and potentially jar'd and deployed.

Since the diagrams are design time only artifacts they should stored in a project folder identified by the user.  A default folder name like "diagrams" would be reasonable so the user can quickly click through diagram creation.
Comment 1 Stefan Dimov CLA 2011-01-20 09:49:02 EST 
I think I'm gonna add another preference/project property 'Diagrams folder:', which default value will be 'diagrams'.
Comment 2 Stefan Dimov CLA 2011-01-24 06:46:09 EST 
Created attachment 187412 [details]
Folder for diagrams - not in src

Now the folder for diagrams is not under src folder. It's a direct project subfolder It's name is defined by user from the preference/property page. By default it's 'diagrams'. If during rename there is an existing folders for diagrams with a diagram in, this folder should be renamed. This is not covered by this patch. It will be tracked in bug #335176
Comment 3 Stefan Dimov CLA 2011-01-24 06:58:25 EST 
Patch committed ...
Comment 4 Stefan Dimov CLA 2011-02-08 10:20:20 EST 
The fix was submitted in the timeframe of M5, but the JPA Diagram Editor wasn't integrated in PDE build of WTP before the M5 release date, so I'm retargeting this bug to M6.
Comment 5 Jolene Moffitt CLA 2011-04-16 09:17:39 EDT 
Verified in Build I-3.3.0-20110414085808

Verified when you create the diagram editor a diagrams folder appears and the .xmi editor appears within the folder.  See the link to view test steps
for verification. http://wiki.eclipse.org/Dali_3.0_M6