Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334161 - Eclipse crashes if link to PDF with anchor is clicked twice from Browser Widget
Summary: Eclipse crashes if link to PDF with anchor is clicked twice from Browser Widget
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.6.2   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 334109 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-01-12 15:30 EST by Chris Goldthorpe CLA
Modified: 2011-01-19 16:44 EST (History)
6 users (show)

See Also:
Silenio_Quarti: review+

Attachments
bundle to reproduce problem (296.93 KB, application/octet-stream)
2011-01-12 15:30 EST, Chris Goldthorpe CLA 		no flags Details
Patch (1.28 KB, patch)
2011-01-12 16:32 EST, Chris Goldthorpe CLA 		no flags Details | Diff
patch (2.05 KB, patch)
2011-01-13 11:02 EST, Grant Gayed CLA 		no flags Details | Diff
revised patch for 3.6.2 (2.00 KB, patch)
2011-01-18 16:21 EST, Grant Gayed CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2011-01-12 15:30:48 EST 
Created attachment 186671 [details]
bundle to reproduce problem

+++ This bug was initially created as a clone of Bug #334109 +++

Build Identifier: Eclipse SDK 3.6.1, also present in Eclipse 3.6 and 3.5, I have not tested earlier versions.

To reproduce:

Unzip the attachment and import as existing project into workspace.
Launch a new Workbench
Open the view PDF Browser View in the PDF category
Press the "Open Frames" Button, two frames should appear
Click on the link "Anchor withing PDF Topic" - PDF opens in right frame
Click again on the same link: Eclipse crashes:

Unhandled exception
Type=Unhandled trap vmState=0x00040000
J9Generic_Signal_Number=00000040 ExceptionCode=c00000fd ExceptionAddress=7C90E8E5 ContextFlags=0001003f
Handler1=7FEFA0C0 Handler2=7FECC180
EDI=16FA86D8 ESI=00000000 EAX=000000A4 EBX=00090000
ECX=16FA86D8 EDX=00000028
EIP=7C90E8E5 ESP=00852F7C EBP=00853030 EFLAGS=00210212
GS=0000 FS=003B ES=0023 DS=0023
Module=C:\WINDOWS\system32\ntdll.dll
Module_base_address=7C900000 Offset_in_DLL=0000e8e5
Target=2_40_20100401_055940 (Windows XP 5.1 build 2600 Service Pack 3)
CPU=x86 (2 logical CPUs) (0xbfe5b000 RAM)
----------- Stack Backtrace -----------
Comment 1 Chris Goldthorpe CLA 2011-01-12 16:32:10 EST 
Created attachment 186679 [details]
Patch
Comment 2 Chris Goldthorpe CLA 2011-01-12 16:33:54 EST 
Comment on attachment 186679 [details]
Patch

Obsoleting attachment. I attached a patch to the wrong bug - unfortunately I don't have a fix for this one.
Comment 3 Felipe Heidrich CLA 2011-01-12 16:49:34 EST 
Why this bug has Component==SWT  ?
Is this a SWT bug ?
Comment 4 Chris Goldthorpe CLA 2011-01-12 16:57:00 EST 
The bug can be reproduced using only SWT code and not the help system, so SWT
is the component that owns it.
Comment 5 Felipe Heidrich CLA 2011-01-12 17:09:19 EST 
(In reply to comment #4)
> The bug can be reproduced using only SWT code and not the help system, so SWT
> is the component that owns it.

can you provide a snippet showing that ? it would help a lot.
Comment 6 Chris Goldthorpe CLA 2011-01-12 17:44:44 EST 
The attachment contains the code necessary to reproduce the problem.
Comment 7 Grant Gayed CLA 2011-01-13 11:02:39 EST 
Created attachment 186739 [details]
patch
Comment 8 Chris Goldthorpe CLA 2011-01-13 14:19:40 EST 
I tested out the patch and it does fix this bug as well as the original variant of the problem as reported in Bug #334109. Can we get this fix into 3.6.2?
Comment 9 Grant Gayed CLA 2011-01-13 14:27:00 EST 
fixed > 20110113 in the 3.7 stream

I think this should be considered for 3.6.2 since it fixes a crash, and I think the change is safe.  SSQ can you review for 3.6.2?
Comment 10 Grant Gayed CLA 2011-01-18 10:11:33 EST 
Comment on attachment 186739 [details]
patch

To update, the initial attached patch introduced a regression in another area, so it's no longer being considered.  I'm investigating alternate fixes.
Comment 11 Grant Gayed CLA 2011-01-18 16:21:31 EST 
Created attachment 187049 [details]
revised patch for 3.6.2
Comment 12 Grant Gayed CLA 2011-01-18 16:23:03 EST 
fixed in the 3.7 and 3.6.2 streams > 20110118
Comment 13 Samuel Wu CLA 2011-01-18 22:08:44 EST 
Thank you, Grant, for the patch. Our product is still on Eclipse 3.6.1. I wonder whether a patch can be created for it.
Comment 14 Grant Gayed CLA 2011-01-19 09:49:18 EST 
I would think that the patch in comment 11 would apply to the code in the 3.6.1 release equally well.
Comment 15 Chris Goldthorpe CLA 2011-01-19 16:41:30 EST 
Verified in M20110119-0834. Thanks for fixing this so quickly.
Comment 16 Chris Goldthorpe CLA 2011-01-19 16:44:50 EST 
*** Bug 334109 has been marked as a duplicate of this bug. ***