Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334136 - [Compatibility] E4HandlerProxy invokes the 3.x handler with an ExecutionEvent that doesn't have a trigger
Summary: [Compatibility] E4HandlerProxy invokes the 3.x handler with an ExecutionEvent...
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 RC3   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331240
  Show dependency tree
 
Reported: 2011-01-12 12:03 EST by Remy Suen CLA
Modified: 2011-06-08 12:59 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-01-12 12:03:15 EST 
The trigger should be non-null if the command is executed through a menu item, tool item, or a keybinding.

http://egit.eclipse.org/w/?p=egit.git;a=blob;f=org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/LinkWithSelectionCommand.java;h=14228d631a99fcb8bc37656cbb0637e0de5292b6;hb=HEAD

Caused by: java.lang.NullPointerException
	at org.eclipse.egit.ui.internal.repository.tree.command.LinkWithSelectionCommand.execute(LinkWithSelectionCommand.java:27)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:58)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:52)
	... 31 more
Comment 1 Remy Suen CLA 2011-01-12 12:06:06 EST 
Technically we do have the trigger for the keybinding case but it is ignored when we actually execute the command. See org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher's executeCommand(ParameterizedCommand, Event) method.
Comment 2 Paul Webster CLA 2011-06-08 12:59:13 EDT 
Fixed by Bug 333506 

PW