Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334109 - Eclipse crashes if link to PDF is clicked twice
Summary: Eclipse crashes if link to PDF is clicked twice
Status: CLOSED DUPLICATE of bug 334161
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: platform-ua-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 09:21 EST by Samuel Wu CLA
Modified: 2011-01-19 16:44 EST (History)
1 user (show)

See Also:

Attachments
Toc file (461 bytes, text/plain)
2011-01-12 09:23 EST, Samuel Wu CLA 		no flags Details
PDF file (14.43 MB, application/octet-stream)
2011-01-12 09:34 EST, Samuel Wu CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Wu CLA 2011-01-12 09:21:41 EST 
Build Identifier: Eclipse SDK 3.6.1

We have a pdf link in our help. The first time the toc item is selected, the pdf book is opened properly. The second time the same toc item is selected, Eclipse crashes. There is no error message in the .log.

Reproducible: Always

Steps to Reproduce:
1. Start Eclipse SDK 3.6.1 and create a plugin using sample help template
2. Use the attached tocreference.xml to replace the generated one.
3. Save the attached PDF file in the plugin project
4. Launch runtime work bench and open the help
5. Click the toc item My topic under Main Topic 2 of Reference to open the PDF book
6. Click My topic again and the eclipse will crash
Comment 1 Samuel Wu CLA 2011-01-12 09:23:15 EST 
Created attachment 186635 [details]
Toc file
Comment 2 Samuel Wu CLA 2011-01-12 09:34:50 EST 
Created attachment 186636 [details]
PDF file
Comment 3 Chris Goldthorpe CLA 2011-01-12 11:14:17 EST 
I have been able to reproduce the crash on Windows XP. I will investigate.
Comment 4 Chris Goldthorpe CLA 2011-01-12 11:45:17 EST 
The problem also shows up in Eclipse 3.6 and Eclipse 3.5, it only happens when the href to the PDF document contains an anchor as in <topic href="dz9zr006.pdf#G29.1169203" >. The problem does not reproduce if an external browser is used.

I'm surprised this has not been reported before since it exists at least back to Eclipse 3.5. The help system browser on Windows uses Internet Explorer to open the pdf file, I don't yet know if the problem is specific to one version of IE.

I have IE 8 on my system, which version were you using?
Comment 5 Samuel Wu CLA 2011-01-12 13:10:21 EST 
My IE is 7.0.5730.13. But I was not using to open the help page. The preferences setting for Open help contents is "In the help browser".
Comment 6 Chris Goldthorpe CLA 2011-01-12 13:33:00 EST 
When you open using the help browser on Windows you are indirectly using Internet Explorer - the SWT Browser widget is built on top of the native browser services, on Windows it uses Internet Explorer.
Comment 7 Samuel Wu CLA 2011-01-13 10:09:17 EST 
I noticed there was a patch appended to bug 334161. Is that patch supposed for this bug? Wonder how to try it out. Failed to find the ScopeSelectPart in the plug-in org.eclipse.help.ui.
Comment 8 Chris Goldthorpe CLA 2011-01-13 14:16:59 EST 
I tried the patch attached to bug 334161 and it does fix this problem!
Comment 9 Chris Goldthorpe CLA 2011-01-19 16:44:50 EST 
I verified using M20110119-0834 that this is now fixed by the patch in Bug 334161

*** This bug has been marked as a duplicate of bug 334161 ***