Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334085 - BrokenFileSystem and WrapperFileSystem refactoring
Summary: BrokenFileSystem and WrapperFileSystem refactoring
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Szymon Ptaszkiewicz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 332543
Blocks:
  Show dependency tree
 
Reported: 2011-01-12 08:14 EST by Szymon Brandys CLA
Modified: 2014-01-24 10:06 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-01-12 08:14:17 EST 
This came up to me while reviewing the fix for bug 332543.

James modified WrapperFileSystem so it could fail when the file store stream is closed. However we already have BrokenFileSystem and BrokenFileStore which was created to emulate errors in file stores. BrokenFileStore fails in other cases too though.

We could make BrokenFS more general, so it could be used in the James' test. Maybe other ideas?
Comment 1 James Blackburn CLA 2011-01-12 08:21:02 EST 
Or alternatively implement BrokenFS in terms of WrapperFS.

For regression tests it's useful to start from a working FS, introducing the suspect behaviour along with the test for handling the behaviour.  [BrokenFS starts from the other position: most operations fail...]
Comment 2 Szymon Brandys CLA 2011-03-24 06:36:36 EDT 
Moving to 3.8. Szymon P., feel free to move it back to 3.7, if you have time to fix it.
Comment 3 Szymon Ptaszkiewicz CLA 2014-01-24 10:06:25 EST 
I investigated this bug and the scope of work that would need to be done and I think the risk of corrupting existing tests it too big. Existing test file system implementations are tightly coupled with tests they were written for and changing them now could introduce unexpected bugs in tests. Closing as WONTFIX.