Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334067 - [browser]Avoid invoking _getUrl inside MapUrlToZone callback
Summary: [browser]Avoid invoking _getUrl inside MapUrlToZone callback
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 06:11 EST by wuzhe CLA
Modified: 2011-01-13 12:40 EST (History)
3 users (show)

See Also:

Attachments
patch (2.82 KB, patch)
2011-01-12 06:13 EST, wuzhe CLA 		no flags Details | Diff
patch (2.13 KB, patch)
2011-01-12 10:53 EST, Grant Gayed CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description wuzhe CLA 2011-01-12 06:11:12 EST 
Build Identifier: 3.6.1

In side WebSite.java, MapUrlToZone callback invokes _getUrl() each time as part of the condition of whether is in setText mode. This will lower the performance. We can set a flag instead. Path provided as a reference.

Reproducible: Always
Comment 1 wuzhe CLA 2011-01-12 06:13:35 EST 
Created attachment 186613 [details]
patch

Patch.
Comment 2 Grant Gayed CLA 2011-01-12 10:53:05 EST 
Created attachment 186645 [details]
patch

That does get invoked a lot, attached is a revised patch.
Comment 3 Grant Gayed CLA 2011-01-12 10:54:18 EST 
fixed > 20110112
Comment 4 mukundan desikan CLA 2011-01-13 12:24:43 EST 
Grant

Will it be possible to fix this in  SWT 3.6.2 stream?
Comment 5 Grant Gayed CLA 2011-01-13 12:40:16 EST 
This is not appropriate for 3.6.2.  It's not an important enough fix (not a crash or functional regression), and there's not enough time to run with it in the 3.7 stream to gain confidence that there is not a regression being introduced.