Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334051 - Implement method sometimes doesn't add class name to methods in .cpp
Summary: Implement method sometimes doesn't add class name to methods in .cpp
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-refactoring (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.0.2   Edit
Assignee: Emanuel Graf CLA
QA Contact: Emanuel Graf CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 19:14 EST by Marc-André Laperle CLA
Modified: 2011-01-12 05:23 EST (History)
1 user (show)

See Also:

Attachments
Implement method, qualified name patch (2.00 KB, patch)
2011-01-11 20:40 EST, Marc-André Laperle CLA 		no flags Details | Diff
Implement method, qualified name patch (1.99 KB, text/plain)
2011-01-11 20:42 EST, Marc-André Laperle CLA 		emanuel: iplog+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2011-01-11 19:14:08 EST 
CDT 8.0.0.201101051202

I can't attach the code to help reproduce the bug but here's an illustration:

Foo.h:

class Foo
{
  void bar();
};

Results in...

Foo.cpp:

void bar()
{

}

I will try to reproduce it with a simple code or attach a patch.
Comment 1 Marc-André Laperle CLA 2011-01-11 20:40:36 EST 
Created attachment 186588 [details]
Implement method, qualified name patch

checkFileNameAndLocation was only checking the first node location, nodes can have multiple locations.
Comment 2 Marc-André Laperle CLA 2011-01-11 20:42:45 EST 
Created attachment 186589 [details]
Implement method, qualified name patch

Oops, removed redundant boolean check.
Comment 3 Emanuel Graf CLA 2011-01-12 04:36:21 EST 
Fixed in 7.0 and HEAD > 20110112