Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334041 - [client] [IE8] Outline for JavaScript file does not display
Summary: [client] [IE8] Outline for JavaScript file does not display
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 0.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 17:23 EST by Mark Macdonald CLA
Modified: 2011-09-01 11:41 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-01-11 17:23:13 EST
Steps to reproduce (using Internet Explorer 8):
1. Log into the Orion web UI.
2. Open a .js file in coding.html.
3. Show the outline pane (on the left-hand side) if it's not already visible.
4. The outline for the JavaScript file is not displayed.
If you use Firefox 3.6, the outline displays as expected.



Previous discussion:
1.MALGORZATA M. JANCZARSKA Dec 10, 2010 9:18 A.M.
Added attachment empty_outline.bmp

2.SZYMON M. BRANDYS Dec 10, 2010 9:58 A.M.
I see the same problem. I asked Simon to check that too. It looks like a serious limitation.

3.Simon Kaegi Dec 10, 2010 10:12 A.M.
I'm not getting an outline in IE9 and Chrome as well.

4.Boris Bokowski Dec 10, 2010 10:13 A.M.
This is because IE 8 does not have web workers. We should be more explicit about this in the UI (and work on a story that would allow the outline to work on IE).

5.Silenio Quarti Dec 10, 2010 10:17 A.M.
We are aware of this problem. The editor IFRAME is put in IE7 compatibility mode. IE7 does not support outline. There is a considerable amount of work to make the editor run in IE8 mode (we have some work in progress) and there are some disadvantages as well, specially in terms of performance (IE8 is much slower). The same performance problem does not happen in IE9, so we were hoping to just forget about IE8 all together.

6.MALGORZATA M. JANCZARSKA Dec 10, 2010 10:17 A.M.
I have the outline at Chrome, version 8.0.552.215. Have you tried to clear browser cache? Szymon did not see the outline in FF and after cleaning cache it started working. This unfortunately did not help for IE8.

7.Silenio Quarti Dec 10, 2010 10:19 A.M.
Oops. I may be talking about a different problem. I am talking about the outline box to show the matching brackets.

8.Simon Kaegi Dec 10, 2010 10:27 A.M.
Yes, even with a fresh cache I still have problems on Chrome [same version as you but Win7]. Using the console I see:

Error: No service of type [IEditorSyntaxChecker] is available  -- syntaxchecker.js:37Error: No service of type [IEditorSyntaxChecker] is available

9.MALGORZATA M. JANCZARSKA Dec 10, 2010 10:39 A.M.
Silenio, can you look and the attached screenshot? The outline does not contain any entry, although the same file opened on FF displays function names.
I've just noticed that outline works for html pages as well: it displays all the names from html "id" attribute. And this works fine on my IE8.

10.Simon Kaegi Dec 10, 2010 10:43 A.M.
No problem in Chrome now, I had to go in and explicitly delete entries in my localStorage.

I can also get this to work in IE9 by explicitly setting the document mode to ie9 standard.

Does anyone know why we have <meta http-equiv="X-UA-Compatible" content="IE=8"> on the navigator page?

11.Mark MacDonald Dec 10, 2010 10:51 A.M.
Simon: because the Dojo dialogs will only work when IE9 is running in IE8 mode.

12.Mark MacDonald Dec 10, 2010 10:58 A.M.
@Simon comment #8 -- did you try hitting one of the nav pages (navigate-tree or navigate-table) before loading coding.html, after you cleared your localstorage?
There's a known issue where going to coding.html with an empty localstore breaks the syntax checker: see "Initial load of coding.html shows error dialog".

13.Simon Kaegi Dec 10, 2010 11:48 A.M.
In IE8 mode we fail to load the JSLintEditorSyntaxChecker because the service is using "addEventListener" -- in ie8 its attachEvent

document.addEventListener("DOMContentLoaded", function() -- jslintPlugin.js line 28

14.Felipe Heidrich Dec 10, 2010 12:01 P.M.
Simon, about the <meta http-equiv="X-UA-Compatible" content="IE=8">.
It is not only dojo that needs that. You change that to IE-9 and the content type for the editor's iframe will get set to quirks (no good).).

Anyhow, this bug should not be filed against the editor, I'm moving it to IDE.
Comment 1 Mark Macdonald CLA 2011-02-03 10:40:30 EST
(Using IE9 set to IE8 mode)
This works now. I see the outline when I open a JavaScript file.
Comment 2 Mark Macdonald CLA 2011-02-08 15:48:55 EST
This was actually fixed in 0.2M5 by Simon's changes to the
Comment 3 Mark Macdonald CLA 2011-02-08 15:50:47 EST
(In reply to comment #2)
Pretend that says "This was actually fixed in 0.2M5."