Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334019 - SWTException when canceling profile launch configuration
Summary: SWTException when canceling profile launch configuration
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 13:58 EST by Joel Cayne CLA
Modified: 2016-05-05 10:59 EDT (History)
3 users (show)

See Also:
jcayne: review+

Attachments
Patch (1.50 KB, patch)
2011-01-13 10:35 EST, Mike Reid CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Cayne CLA 2011-01-11 13:58:49 EST 
1. Open the profile launch configuration for a new launch, such as an external Java application.
2. Select the profile settings tab and close the launch configuration.

An SWTException error indicating the widget is disposed is output to the error log for org.eclipse.hyades.trace.ui.internal.launcher.ProfileTab.update(ProfileTab.java:52).
Comment 1 Jonathan West CLA 2011-01-12 11:30:40 EST 
Joel, do you have the full exception for this error? From looking at the history, no non-trivial changes have been made to this particular file since 2007.
Comment 2 Mike Reid CLA 2011-01-12 11:35:28 EST 
Jon, its a corner case arising from 333983. I made the (incorrect) assumption that the profiling configurations window will be present when the notification is ready to be displayed.

In fact it is possible to dismiss the profile configurations dialog before the AC validation job is finished, resulting in this error.

Feel free to assign it my way..
Comment 3 Jonathan West CLA 2011-01-12 11:45:25 EST 
Can do!
Comment 4 Mike Reid CLA 2011-01-13 10:35:02 EST 
Created attachment 186733 [details]
Patch

Patch attached checks if profiling tab has been disposed before performing any UI work.
Comment 5 Kathy Chan CLA 2011-01-14 16:10:01 EST 
Please have this checked into TPTP 4.7.2 once the patch has been reviewed.
Comment 6 Mike Reid CLA 2011-01-14 16:37:57 EST 
Joel, can you review this patch?
Comment 7 Joel Cayne CLA 2011-01-17 09:15:53 EST 
Patch looks good.
Comment 8 Mike Reid CLA 2011-01-17 09:52:13 EST 
Checked into HEAD.
Comment 9 Joel Cayne CLA 2011-01-18 09:44:56 EST 
Verified no error was displayed in the error log when canceling the profile launch before AC validation on TPTP-4.7.2-201101171730.