Community
Participate
Working Groups
Hello, AbstractEmfFacetCatalog comes with too many risks of bugs. We then need to replace the AbstractEmfFacetCatalog by a simple catalog manager which use EMF to store/represent its state and which only uses an extension point to declare the catalog entries (no builder). Regards, Gregoire Dupe
Created attachment 186523 [details] org.eclipse.emf.facet.common.core.catalog The authors of the plugin org.eclipse.emf.facet.common.core.catalog are : Gregoire Dupe (Commiter) Nicolas Guyomar
Created attachment 186524 [details] org.eclipse.emf.facet.efacet.catalog The authors of the plugin org.eclipse.emf.facet.efacet.catalog are : Gregoire Dupe (Commiter) Nicolas Guyomar
Created attachment 186525 [details] org.eclipse.emf.facet.efacet.catalog.tests The author of org.eclipse.emf.facet.efacet.catalog.tests is : Nicolas Guyomar
Created attachment 186526 [details] org.eclipse.emf.facet.efacet.core The authors of the plugin org.eclipse.emf.facet.efacet.core are : Gregoire Dupe (Commiter) Nicolas Guyomar
Created attachment 186527 [details] org.eclipse.emf.facet.common.core The authors of the patch org.eclipse.emf.facet.common.core are : Gregoire Dupe (Commiter) Nicolas Guyomar
Hi, (a) I, Nicolas Guyomar, wrote 100% of the code I've provided in the plug-ins : - org.eclipse.emf.facet.common.core.catalog - org.eclipse.emf.facet.efacet.catalog - org.eclipse.emf.facet.efacet.catalog.tests - org.eclipse.emf.facet.efacet.core and in the patch : - - org.eclipse.emf.facet.common.core (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. Regards Nicolas Guyomar
Comment on attachment 186524 [details] org.eclipse.emf.facet.efacet.catalog Moved to bug 333553
Comment on attachment 186525 [details] org.eclipse.emf.facet.efacet.catalog.tests Moved to bug 333553
Comment on attachment 186526 [details] org.eclipse.emf.facet.efacet.core Moved to bug 333553
Created attachment 186606 [details] org.eclipse.emf.facet.common.core HI, I have added documentation to the patch. Regards Nicolas Guyomar
Created attachment 186607 [details] org.eclipse.emf.facet.common.core.catalog Hi, I have added some documentation to the plug-in. Regards Nicolas Guyomar
Comment on attachment 186607 [details] org.eclipse.emf.facet.common.core.catalog Here are contributions from an employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327).
Hello, I've committed the plug-in org.eclipse.emf.facet.common.core.catalog. (Committed revision 191.) Regards, Gregoire Dupe
Comment on attachment 186606 [details] org.eclipse.emf.facet.common.core Hello, I've committed this patch and added some copyright comments and documentations. Committed revision 192. Regards, Gregoire
I've added the plug-in org.eclipse.emf.facet.common.core.catalog in the feature "org.eclipse.emf.facet.common.feature". Committed revision 197.
Hi, Catalog features have to be stored in a plug-in named org.eclipse.emf.facet.util.emf.core. Regards, Gregoire Dupe
Created attachment 187130 [details] org.eclipse.emf.facet.util.emf.core plug-in You can find in the attachment an archive of a new plug-in (org.eclipse.emf.facet.util.emf.core). I've created this plug-in by coping existing code from EMF Facet. Next step: remove the old version of the catalog framework and update the uses. Regards, Gregoire Dupe
Comment on attachment 187130 [details] org.eclipse.emf.facet.util.emf.core plug-in I've committed this plug-in. Committed revision 228.
I've removed the old version of the catalog feature from org.eclipse.emf.facet.common.core and I’ve updated the uses of the catalog features. Committed revision 229. Next step: rename the plug-in org.eclipse.emf.facet.common.core.catalog to org.eclipse.emf.facet.util.emf.core.catalog.
I've added the plug-in "org.eclipse.emf.facet.util.emf.core" in the feature "org.eclipse.emf.facet.common". Committed revision 233.
I've renamed the plug-in org.eclipse.emf.facet.common.core.catalog to org.eclipse.emf.facet.util.emf.catalog.
To improve the API of the catalog feature, I’ve defined the eClass catalog::Catalog as an interface and moved the interface ICatalogManager to the package org.eclipse.emf.facet.util.emf.core. Committed revision 241.
This bug can be closed.