Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333983 - [Accessibility] Legacy AC warning dialog fails accessibility tests
Summary: [Accessibility] Legacy AC warning dialog fails accessibility tests
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 09:52 EST by Mike Reid CLA
Modified: 2016-05-05 11:18 EDT (History)
2 users (show)

See Also:
jcayne: review+

Attachments
Patch (4.59 KB, patch)
2011-01-11 09:53 EST, Mike Reid CLA 		no flags Details | Diff
Updated patch (7.24 KB, patch)
2011-01-11 12:58 EST, Mike Reid CLA 		no flags Details | Diff
Patch to re-use existing 'Warning' message (3.06 KB, patch)
2011-01-21 10:54 EST, Mike Reid CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reid CLA 2011-01-11 09:52:00 EST 
Bug 323137 introduced detection and warning of legacy Agent Controllers (i.e. ACs where the new exec framework is unsupported). However the warning dialog used is not accessible on several counts: mouse keys don't work properly, expanding details crashes JAWS, high contrast mode results in unreadable text, etc.

This bug is opened to correct these issues.
Comment 1 Mike Reid CLA 2011-01-11 09:53:21 EST 
Created attachment 186505 [details]
Patch

Patch to fix accessibility problems.
Comment 2 Mike Reid CLA 2011-01-11 10:00:49 EST 
Joel can you please review this patch?

The patch simply replaces the use of the "StatusManager" mechanism with org.eclipse.jface.dialogs.ErrorDialog, which is more accessibility friendly.
Comment 3 Mike Reid CLA 2011-01-11 12:58:19 EST 
Created attachment 186534 [details]
Updated patch

Updated patch with comments from Joel.
Comment 4 Joel Cayne CLA 2011-01-11 13:51:42 EST 
Patch looks good.
Comment 5 Kathy Chan CLA 2011-01-12 11:19:03 EST 
Project approved for 4.7.2.
Comment 6 Mike Reid CLA 2011-01-12 11:31:33 EST 
Patch checked into HEAD.
Comment 7 Mike Reid CLA 2011-01-21 10:52:37 EST 
Re-opening. The accessibility fix introduced a new "Warning" string whereas one already exists in the same .properties file. To save on translation resources, pulling out the new string and just referencing the existing string.
Comment 8 Mike Reid CLA 2011-01-21 10:54:13 EST 
Created attachment 187294 [details]
Patch to re-use existing 'Warning' message

Re-use warning patch attached.
Comment 9 Mike Reid CLA 2011-01-21 10:55:56 EST 
'Warning' re-use patch checked into HEAD.
Comment 10 Mike Reid CLA 2011-04-04 11:07:56 EDT 
Closing.