333941 – Missing semicolon doesn't show squiggly line

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333941 - Missing semicolon doesn't show squiggly line

Summary: Missing semicolon doesn't show squiggly line

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-parser (show other bugs)
Version:	8.0
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	---
Assignee:	Markus Schorn
QA Contact:	Markus Schorn

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-01-11 00:32 EST by Marc-André Laperle
Modified:	2011-01-27 05:23 EST (History)
CC List:	1 user (show)

See Also:

Attachments
fix (5.56 KB, patch) 2011-01-26 11:55 EST, Markus Schorn	mschorn.eclipse: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc-André Laperle

2011-01-11 00:32:57 EST

As a consequence of the solution in bug 314593, some missing semicolon syntax errors don't show a squiggly line anymore. 

For example:

printf()
return;

There will be an icon in the vertical ruler but no squiggly line. I find that when I'm typing, I'm paying more attention to the squiggly lines than the vertical ruler, so I miss it. I would be great if it could look like JDT, see
https://bugs.eclipse.org/bugs/attachment.cgi?id=170127

Comment 1 Markus Schorn

2011-01-26 11:54:06 EST

JDT seems to mark the last token before the missing semicolon. A similar solution for c/c++ is hard to accomplish. We could mark the last character
before the missing semicolon, though.

Comment 2 Markus Schorn

2011-01-26 11:55:50 EST

Created attachment 187654 [details]
fix

Comment 3 Markus Schorn

2011-01-26 11:58:29 EST

Fixed in 8.0 > 20110126.

Comment 4 CDT Genie

2011-01-26 12:23:03 EST

*** cdt cvs genie on behalf of mschorn ***
Bug 333941: Squiqgly line for missing semicolons.

[*] ASTProblem.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ASTProblem.java?root=Tools_Project&r1=1.14&r2=1.15
[*] AbstractGNUSourceCodeParser.java 1.157 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/AbstractGNUSourceCodeParser.java?root=Tools_Project&r1=1.156&r2=1.157

[*] IProblem.java 1.25 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/parser/IProblem.java?root=Tools_Project&r1=1.24&r2=1.25

[*] GNUCSourceParser.java 1.156 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/c/GNUCSourceParser.java?root=Tools_Project&r1=1.155&r2=1.156

[*] ParserMessages.properties 1.32 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/ParserMessages.properties?root=Tools_Project&r1=1.31&r2=1.32

[*] GNUCPPSourceParser.java 1.247 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/GNUCPPSourceParser.java?root=Tools_Project&r1=1.246&r2=1.247

Comment 5 CDT Genie

2011-01-27 05:23:02 EST

*** cdt cvs genie on behalf of mschorn ***
Bug 333941: Adjust testcase.

[*] FaultToleranceTests.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/FaultToleranceTests.java?root=Tools_Project&r1=1.6&r2=1.7