Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333925 - Inefficiency in HTMLResourceEncodingDetector
Summary: Inefficiency in HTMLResourceEncodingDetector
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard: WI60406
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-10 19:01 EST by Nick Sandonato CLA
Modified: 2011-01-12 18:01 EST (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
patch (1.24 KB, patch)
2011-01-10 19:03 EST, Nick Sandonato CLA 		no flags Details | Diff
patch with end-of-stream check (1.70 KB, patch)
2011-01-12 15:20 EST, Nick Sandonato CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2011-01-10 19:01:28 EST 
Currently, the HTMLResourceEncodingDetector does a ready() check before reading a byte. For sufficiently large files, or when the detector has to run over several files, this can cause the checkheuristics() method to take up a considerable amount of time. I don't think anything is bought by bailing out when a resource isn't ready and may be more troublesome since we can't check the heuristics to determine the encoding.

In running tests, I noticed a performance gain of nearly 82% from just not doing the ready() check.
Comment 1 Nick Sandonato CLA 2011-01-10 19:03:13 EST 
Created attachment 186446 [details]
patch
Comment 2 Nitin Dahyabhai CLA 2011-01-12 14:52:09 EST 
This isn't new, but what if fReader.read() returns -1?
Comment 3 Nick Sandonato CLA 2011-01-12 15:20:03 EST 
Created attachment 186668 [details]
patch with end-of-stream check
Comment 4 Nick Sandonato CLA 2011-01-12 18:01:56 EST 
Code checked in. Thanks.