Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333903 - Need to update JS include path after module core nature installed
Summary: Need to update JS include path after module core nature installed
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Web (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on: 329397 334922
Blocks:
  Show dependency tree
 
Reported: 2011-01-10 15:04 EST by Ian Tewksbury CLA
Modified: 2011-03-16 16:14 EDT (History)
0 users

See Also:
itewksbu: review?

Attachments
Fix Patch (18.03 KB, patch)
2011-01-10 16:23 EST, Ian Tewksbury CLA 		no flags Details | Diff
Fix Patch - Update 1 (40.47 KB, patch)
2011-01-20 14:44 EST, Ian Tewksbury CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2011-01-10 15:04:33 EST 
This needs fixing in 3.3 as well.

+++ This bug was initially created as a clone of Bug #333901 +++

right now if the module core nature gets installed after the JS class path is set up then the JS class path will only have the default entry instead of the more correct module core nature determined entries.

This needs to be fixed so that if at any point the module core nature gets installed on a project its class path entries are updated correctly.
Comment 1 Ian Tewksbury CLA 2011-01-10 16:23:53 EST 
Created attachment 186431 [details]
Fix Patch

Same as the fix for Bug 333901 except it adds new strings that are more descriptive.
Comment 2 Ian Tewksbury CLA 2011-01-20 14:44:52 EST 
Created attachment 187232 [details]
Fix Patch - Update 1

This patch updates the last patch such that any exclude or include paths on
existing class path entries that will be removed by this action are brought
forward to the new ones where appropriate.

Because the logic for moving exclude and include paths forward is a bit complex
I have added a suite of JUnits to test that part of the patch.
Comment 3 Nitin Dahyabhai CLA 2011-03-16 16:14:07 EDT 
Fixed based on the final patch for bug 333901.