Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333843 - each subclass of AbstractCatalogView saves column widths for all subclasses
Summary: each subclass of AbstractCatalogView saves column widths for all subclasses
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Infrastructure (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0 M5   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-10 04:03 EST by Nicolas Bros CLA
Modified: 2011-04-28 10:43 EDT (History)
2 users (show)

See Also:
nicolas.bros: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-01-10 04:03:11 EST 
Each subclass of AbstractCatalogView saves the whole map of column widths (shared by all subclasses), even though they don't use them.
Comment 1 Nicolas Bros CLA 2011-01-10 04:11:33 EST 
This comes from the fact that COLUMN_WIDTHS is static. It was made static because we want to be able to save column widths during the session, instead of only when the workbench is closed (which is the case with ViewPart#saveState).
Comment 2 Nicolas Bros CLA 2011-01-10 09:13:26 EST 
I fixed the problem, refactored AbstractCatalogView, created PersistableColumn to factor common functionality, and created wrappers for JFace columns that work for both tables and trees.

Committed in revision 3699.
Comment 3 Hugo Bruneliere CLA 2011-01-11 05:25:12 EST 
Bug fixed.