Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333814 - RevertCommand and CherryPickCommand should not create empty commit
Summary: RevertCommand and CherryPickCommand should not create empty commit
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 0.10.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-09 19:32 EST by Matthias Sohn CLA
Modified: 2011-01-10 10:51 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Sohn CLA 2011-01-09 19:32:27 EST 
Found this with the new egit revert operation in the history view:
- revert a commit which has been already reverted manually in a subsequent commit
- alternatively revert the same commit twice
- egit/jgit will then create an empty revert commit, c git doesn't create a commit in these cases
Comment 1 Robin Rosenberg CLA 2011-01-10 01:58:18 EST 
The same bug applies to CherryPick, of which RevertCommand is a clone
Comment 2 Robin Rosenberg CLA 2011-01-10 02:53:05 EST 
See http://egit.eclipse.org/r/2225
Comment 3 Matthias Sohn CLA 2011-01-10 10:51:05 EST 
jgit change merged as 2058f9272b33753c695fb57bf9126371d3ab7cec
egit change merged as 8cf9cf5a335e3f2fd1c4b85ffeffbbd2b15a0ea5