Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333774 - 'Result' view has strange coding pattern
Summary: 'Result' view has strange coding pattern
Status: CLOSED FIXED
Alias: None
Product: Acceleo
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-07 12:52 EST by Remy Suen CLA
Modified: 2011-02-08 08:41 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-01-07 12:52:21 EST 
In the AcceleoResultView, a selection listener is attached to the returned value of PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage(). It's not clear to me why this is used when getSite().getPage() could just be used instead.

Also, if multiple views are opened and the user switches to another workbench window in between this action, the returned workbench page might not be the same workbench page as the one that the created view is in so now you're listening to selections from some other workbench window instead of your own.
Comment 1 Stephane Begaudeau CLA 2011-02-08 08:41:57 EST 
Contributed on HEAD, it will be available in Acceleo 3.1.0 M6