Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333679 - refactor jetty-jmx
Summary: refactor jetty-jmx
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: build (show other bugs)
Version: 7.2.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 7.3.x   Edit
Assignee: Hugues Malphettes CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-06 13:00 EST by Greg Wilkins CLA
Modified: 2011-01-12 04:05 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Wilkins CLA 2011-01-06 13:00:01 EST 
The jetty-jmx bundle contains both the jmx infrastructure and specific mbeans and meta data.

the mbeans and meta data need to be moved to the appropriate modules.
Comment 1 Greg Wilkins CLA 2011-01-06 13:08:14 EST 
I've done the refactor, but broken the osgi module as a result.

The jetty-jmx is now an optional dependency of modules like jetty-deploy and jetty-server.   The osgi-boot already has jmx as optional, but the osgi tests are saying it cannot be resolved?

tests are currently commented

HELP!
Comment 2 Hugues Malphettes CLA 2011-01-12 04:04:37 EST 
As commented on the jetty-dev mailing list:
the few modules that optionally depend on org.eclipse.jetty.jmx needed an extra instruction for the maven-bundle plugin to mark the corresponding import-package as optional.
The following was added to jetty-deploy, jetty-server and jetty-servlet.
I have not found other modules that need this modification but please do correct me if I missed another module that expose an MBean and depends on jetty-jmx for that reason.

      <plugin>
        <groupId>org.apache.felix</groupId>
        <artifactId>maven-bundle-plugin</artifactId>
        <version>${felix.bundle.version}</version>
        <extensions>true</extensions>
        <executions>
          <execution>
            <goals>
              <goal>manifest</goal>
            </goals>
            <configuration>
              <instructions>
                <Import-Package>org.eclipse.jetty.jmx.*;version="[7.3,8)";resolution:=optional,*</Import-Package>
              </instructions>
            </configuration>
           </execution>
        </executions>
      </plugin>
Comment 3 Hugues Malphettes CLA 2011-01-12 04:05:22 EST 
Fixed for 7.3.x with revision 2652