Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333670 - Inconsistent behavior of getRevisionByVersion()
Summary: Inconsistent behavior of getRevisionByVersion()
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Egidijus Vaisnora CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-06 11:19 EST by Egidijus Vaisnora CLA
Modified: 2011-06-23 03:40 EDT (History)
1 user (show)

See Also:
stepper: review+

Attachments
Patch v1 (20.39 KB, patch)
2011-01-06 11:38 EST, Egidijus Vaisnora CLA 		no flags Details | Diff
Patch v2 (20.38 KB, patch)
2011-01-08 10:46 EST, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Egidijus Vaisnora CLA 2011-01-06 11:19:22 EST 
Cloned from: 315043: Inconsistent behavior of getRevisionByVersion()
https://bugs.eclipse.org/bugs/show_bug.cgi?id=315043

Build Identifier: 3.0

getRevisionByVersion on detached revision returns null or DetachedCDORevision, regarding the local cache.
Expected result, to have method working the same way. 
Perhaps it is worth to consider return DetachedCDORevision for detached revision version and *null* for non existing version

Reproducible: Always

Steps to Reproduce:
test
Comment 1 Egidijus Vaisnora CLA 2011-01-06 11:38:31 EST 
Created attachment 186192 [details]
Patch v1

Adopted patch from the 3.0
Comment 2 Egidijus Vaisnora CLA 2011-01-06 11:40:39 EST 
Removed assignment
Comment 3 Egidijus Vaisnora CLA 2011-01-06 11:42:10 EST 
Ready for review
Comment 4 Eike Stepper CLA 2011-01-08 10:46:02 EST 
Created attachment 186327 [details]
Patch v2

Reformatted test.
Comment 5 Eike Stepper CLA 2011-01-08 10:46:46 EST 
Please commit patch v2 ;-)
Comment 6 Egidijus Vaisnora CLA 2011-01-10 04:43:19 EST 
Committed to HEAD
Comment 7 Eike Stepper CLA 2011-06-23 03:40:26 EDT 
Available in R20110608-1407