Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333658 - Polish Use Scan Feature III
Summary: Polish Use Scan Feature III
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 331954
Blocks:
  Show dependency tree
 
Reported: 2011-01-06 10:20 EST by Curtis Windatt CLA
Modified: 2011-01-26 12:49 EST (History)
2 users (show)

See Also:
ankur_sharma: review+

Attachments
Fix (17.59 KB, patch)
2011-01-06 12:25 EST, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-01-06 10:20:43 EST 
1) Separate the setence with the link to a new paragraph (at the bottom?).  It is a little hard to read what is going on.

2) Use the applyData method to open the api errors/warnings to the correct tab.

3) Removing use scans or pressing restore defaults still affects the preferences even if cancel is pressed.
Comment 1 Curtis Windatt CLA 2011-01-06 12:25:38 EST 
Created attachment 186199 [details]
Fix
Comment 2 Curtis Windatt CLA 2011-01-06 12:29:06 EST 
Fixed in HEAD.  See patch for changes.

Ankur please verify.

In regards to the performance with the removal of the cache, I tested with a reasonably large use scan and didn't have any issues.  However, if you believe there is an issue with 1000 as the default, we need to provide a better solution than just a preference.  The user has no way of knowing what the cache does, what a reasonable value is and how large a reference is.
Comment 3 Ankur Sharma CLA 2011-01-07 06:35:05 EST 
+1

I am good if you have already tested it with a large use scan
Comment 4 Curtis Windatt CLA 2011-01-26 12:49:08 EST 
Verified in I20110126-0800