Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333651 - Remove of the MoDisco EPackage view and of the metamodel browsing button
Summary: Remove of the MoDisco EPackage view and of the metamodel browsing button
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Main (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0 M5   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 333652
Blocks:
  Show dependency tree
 
Reported: 2011-01-06 08:44 EST by Gregoire Dupe CLA
Modified: 2011-01-11 09:25 EST (History)
1 user (show)

See Also:
gdupe: indigo+

Attachments
Bug 333651 (34.55 KB, patch)
2011-01-07 11:56 EST, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregoire Dupe CLA 2011-01-06 08:44:46 EST 
Hello,

Since the MoDisco EPackage view and the metamodel browsing button have been copied in EMF Facet, they have to be removed from MoDisco.

An extension point offering the possibility to declare an EPackage browser is needed to be able to use the MoDisco browser to display the meta-models.

MoDisco has to declare an extension to this extension point.

Regards,
Gregoire Dupe
Comment 1 Nicolas Guyomar CLA 2011-01-07 11:56:56 EST 
Created attachment 186290 [details]
Bug 333651

Hi,

Please find attached the code modification to meet the requirements of this bug.

(a) I, Nicolas Guyomar, wrote 100% of the code of the patch.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards

Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-01-11 05:25:39 EST 
Hello,

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

Regards,
Gregoire
Comment 3 Gregoire Dupe CLA 2011-01-11 06:07:32 EST 
I’ve committed the Nicolas Guyomar’s patch.

This patch removes the classes OpenModelFromEmfRegistryAction, UriSelectionDialog, PackageRegistryView because those classes have been copied to EMF Facet.

The use of the MoDisco browser to open EPackage from the EMF Facet’s view is possible thanks to the use of the extension point org.eclipse.emf.facet.util.emf.ui.epackagebrower and the class org.eclipse.gmt.modisco.infra.browser.epackagebrowserEPackageBrowser.

The releng project has been updated because the patch creates a dependency to the EMF Facet project.
Comment 4 Gregoire Dupe CLA 2011-01-11 06:27:59 EST 
Committed revision 3713.
Comment 5 Gregoire Dupe CLA 2011-01-11 09:25:57 EST 
It works with EMF Facet 0.1.0.v201101101615 and MoDisco 0.9.0.v201101111211.

Regards,
Gregoire Dupe