Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333509 - The implementation for bringing up a variable in the memory view is flawed
Summary: The implementation for bringing up a variable in the memory view is flawed
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-memory (show other bugs)
Version: 7.0.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Randy Rohrbach CLA
QA Contact: Ted Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-04 15:29 EST by Randy Rohrbach CLA
Modified: 2011-05-13 11:05 EDT (History)
2 users (show)

See Also:
Randy.Rohrbach: review? (pawel.1.piech)

Attachments
More generic implementation (2.92 KB, patch)
2011-01-04 15:30 EST, Randy Rohrbach CLA 		cdtdoug: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Rohrbach CLA 2011-01-04 15:29:40 EST 
The implementation for bringing up a variable in the memory view is flawed.

It assumes/requires that the IMemoryBlockRetrieval is an instance of
a DsfMmeoryBlockRetrieval. Wind River implements its own IMemoryBlockRetrieval
and does not use the DsfMmeoryBlockRetrieval. 

It needs to be more generically written.

Randy
Comment 1 Randy Rohrbach CLA 2011-01-04 15:30:59 EST 
Created attachment 186044 [details]
More generic implementation
Comment 2 Randy Rohrbach CLA 2011-01-04 15:31:28 EST 
I am taking this one.

Randy
Comment 3 Randy Rohrbach CLA 2011-01-04 15:39:06 EST 
Folks

  I committed these changes to CDT 7.0.1 and HEAD.

  Pawel please review.

Randy