Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333489 - PartSashContainers prevent re-rendering a previously-opened window
Summary: PartSashContainers prevent re-rendering a previously-opened window
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 M5   Edit
Assignee: Project Inbox CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-04 11:03 EST by Brian de Alwis CLA
Modified: 2011-01-07 09:56 EST (History)
1 user (show)

See Also:

Attachments
Patch that cleans up the 'widget' and 'renderer' fields of sashes (1.66 KB, patch)
2011-01-04 15:33 EST, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2011-01-04 11:03:53 EST 
BuildId: e4 4.1M4

Attempting to re-open a window with a PartSashContainer fails as the contents of the PartSashContainers are not re-created.

The direct problem is that the PartSashContainer elements don't have their widget fields nulled out on close.  Thus the widgets are not re-rendered during the IPresentationEngine/PartRenderingEngine.createGui().

The widget field actually contains a Rectangle instance.  The field isn't nulled out as SashRenderer inherits bindWidget from SWTPartRenderer, which only installs the unbindWidget-on-dispose (and thus null the widget field) when the widget actually is a control.
Comment 1 Eric Moffatt CLA 2011-01-04 11:28:06 EST 
Good one...I see the problem, patch / fix coming...
Comment 2 Eric Moffatt CLA 2011-01-04 15:33:07 EST 
Created attachment 186045 [details]
Patch that cleans up the 'widget' and 'renderer' fields of sashes


A MPSC is always created under some real parent Composite. This patch simply adds a dispose listener to the composite containing the layout that explicitly nulls the fields if the owning composite gets disposed.
Comment 3 Eric Moffatt CLA 2011-01-04 15:57:15 EST 
Committed in >20110104. Applied the patch.
Comment 4 Brian de Alwis CLA 2011-01-06 11:17:36 EST 
Verified fix.  Thanks Eric.
Comment 5 Eric Moffatt CLA 2011-01-07 09:56:07 EST 
Np, thanks for the work you're putting in...
Comment 6 Eric Moffatt CLA 2011-01-07 09:56:27 EST 
Marking as FIXED.