Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333443 - The ImportDialog for the transport services has a protected method which is required to be public
Summary: The ImportDialog for the transport services has a protected method which is r...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-memory (show other bugs)
Version: 7.0.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Randy Rohrbach CLA
QA Contact: Ted Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-03 20:18 EST by Randy Rohrbach CLA
Modified: 2011-05-13 11:04 EDT (History)
2 users (show)

See Also:

Attachments
Changes a protected method to be public (946 bytes, patch)
2011-01-03 20:21 EST, Randy Rohrbach CLA 		cdtdoug: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Rohrbach CLA 2011-01-03 20:18:20 EST 
The ImportDialog for the transport services has a protected method which is required to be public.

The method scrollRenderings(BigInteger address) is protected. This has
not been a problem since all of the transports to date have been done
within the same package. 

I am creating a proprietary transport and when I do this method comes up
as unavailable.

It needs to be public. This is technically a change of an API, but I unless
I use reflection to get to this method, it needs to be changed.

I am creating a patch to show this and will discuss, it with the community before committing it.

Randy
781-364-2226
Wind River
Comment 1 Randy Rohrbach CLA 2011-01-03 20:21:54 EST 
Created attachment 185979 [details]
Changes a protected method to be public

It is the case that this method is standardly used in all if the various importers. I am creating a custom importer and do not want to loose the
functionality. It should have been public in the first place.
Comment 2 Randy Rohrbach CLA 2011-01-07 22:31:01 EST 
Well I got only one comment in response and it was a vote for.

So I am applying this change to 7.0.x and 8.0

Randy
Comment 3 Randy Rohrbach CLA 2011-01-07 22:38:02 EST 
I checked the change in to 7.0.1 and 8.0