Description Markus Keller 2011-01-03 07:02:14 EST

Follow-up to bug 74073

(In reply to bug 74073 comment #29 and following)
> Do we really need the new context? It looks weird in the 'Keys' pref page:
> When: 'Workbench'.
> Also, it doesn't seem to work, e.g. if I assign commands using that context
> they won't be enabled - hence the context is very misleading. I think we should
> be very careful in defining a new context and avoid it if possible.

(In reply to bug 74073 comment #33)
> Well, I would interpret 'Workbench' context as the context enabled when a
> workbench is active and not the other way around and I would also expect that
> if I bind an existing command to it (e.g. Save) it will work when a workbench
> window is active.

I think the best solution would be to give the context a correct name (e.g. "No Windows" or "No Windows Shown") and a better ID that corresponds to the new name.

To avoid the confusing UI in applications that don't support the windowless mode, the Keys preference page should hide the unsupported context if IWorkbenchConfigurer#getExitOnLastWindowClose() is false.