Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333390 - [Compatibility] Workbench window selection does not appear to change immediately when active part switches
Summary: [Compatibility] Workbench window selection does not appear to change immediat...
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.1 M6   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-02 15:54 EST by Remy Suen CLA
Modified: 2011-03-08 14:13 EST (History)
2 users (show)

See Also:

Attachments
SelectionService patch v1 (3.73 KB, patch)
2011-01-04 10:33 EST, Remy Suen CLA 		no flags Details | Diff
SelectionService patch v2 (1.88 KB, patch)
2011-02-02 08:16 EST, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-01-02 15:54:01 EST 
From looking at the code, it seems that we appropriately detach/attach listeners based on the active part but don't actually send out a notification that the selection has changed (if one part's selection differs from another part's).
Comment 1 Remy Suen CLA 2011-01-04 10:33:21 EST 
Created attachment 186011 [details]
SelectionService patch v1
Comment 2 Remy Suen CLA 2011-01-04 10:34:48 EST 
(In reply to comment #1)
> Created attachment 186011 [details]
> SelectionService patch v1

Fix released to CVS HEAD. Thanks for the bug report, Thomas!
Comment 3 Remy Suen CLA 2011-01-26 08:33:15 EST 
Does not work with I20110125-2200 on Windows XP. It is okay in the inner but not the outer. Even if the inner only consists of plug-ins in the host target platform, the problem cannot be reproduced.
Comment 4 Remy Suen CLA 2011-02-02 08:16:05 EST 
Created attachment 188133 [details]
SelectionService patch v2

Can no longer reproduce on I20110125-2200 or I20110128-2000 for some reasons. Here's a patch which should ensure that the change in workbench window selection is propagated.
Comment 5 Remy Suen CLA 2011-02-02 08:16:52 EST 
(In reply to comment #4)
> Created attachment 188133 [details]
> SelectionService patch v2

Patch released to CVS HEAD.
Comment 6 Remy Suen CLA 2011-03-08 14:13:07 EST 
Verified with I20110307-2200 on Windows XP.