Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333373 - [ui] Show In Package Explorer - Cannot reveal the selected element
Summary: [ui] Show In Package Explorer - Cannot reveal the selected element
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: wst.xml CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
: 334776 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-01-01 09:09 EST by Stanimir Stamenkov CLA
Modified: 2012-11-02 15:28 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stanimir Stamenkov CLA 2011-01-01 09:09:02 EST
Build Identifier: 20100917-0705

When in the XML editor I press Alt+Shift+W (Show In) and select Package Explorer I always get the message:

"Cannot reveal the selected element. Do you want to remove some filters to reveal the element?"

Choosing "Yes" makes the file properly selected in the Package Explorer but then it turns the view filters off, while the filters don't really hide the file.  Placing the cursor at the end of the XML file and issuing the same makes the file selected in the Package Explorer without giving the "cannot reveal" dialog.

"Show In -> Navigator" works as expected no matter where the insertion point is currently in the editor.

"Show In -> Project Explorer" doesn't display "cannot reveal" dialog, but doesn't select the file in the view, unless I position the caret at the end of the editor.

Reproducible: Always

Steps to Reproduce:
1. Open an XML file in the "Java" perspective;
2. Position the insertion point in the middle of the file;
3. Choose Navigate -> Show In -> Package Explorer.
Comment 1 Rakesh CLA 2011-01-20 05:46:50 EST
If we look into CommonNavigator.getSelection(ShowInContext context) function, there is a condition
		if (selection != null && !selection.isEmpty() && selection instanceof IStructuredSelection)
			return (IStructuredSelection)selection;

Whenever cursor is not at end position selection is not empty, hence we return this selection.This selection for example in case of html could be body or head node.This class is not able to make out file path from this information, hence we don't see it highlighted.

If cursor is at end position, selection is empty and we return FileEditorInput in next line, and it shown properly.
I am not sure how we can fix this since we cannot change the way we provide selection and CommonNavigator class is not provided by us.
Comment 2 Stanimir Stamenkov CLA 2011-02-13 05:23:03 EST
So you the problem lies in the Package/Project Explorer views and not in the XML editor?  Note the Navigator view works just fine - what's the difference which makes it work with it and not with the other views?
Comment 3 Nick Sandonato CLA 2011-10-11 17:39:13 EDT
*** Bug 334776 has been marked as a duplicate of this bug. ***
Comment 4 Nick Sandonato CLA 2012-11-02 15:28:33 EDT
This was fixed by having our DOM adapt to IResource through Bug 208636.