Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333363 - Setting Toolbar menucontribution to visible false makes menu disappear
Summary: Setting Toolbar menucontribution to visible false makes menu disappear
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.1.1   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-31 10:30 EST by Thomas Kratz CLA
Modified: 2011-08-11 06:15 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Kratz CLA 2010-12-31 10:30:26 EST 
Build Identifier: e4M4a

I set the visiblity if a toolbar item based on a variable, that evaluates currently to false. The toolbar item is still shown, but the main menu is gone.



Reproducible: Always

Steps to Reproduce:
this is my menu contribution that should hide the toolbar item
<menuContribution
            allPopups="false"
            locationURI="toolbar:de.eiswind.mango.toolbar.main?after=additions">
         <command
               commandId="de.eiswind.mango.client.onix.ftp.command"
               icon="icons/ftp.gif"
               label="Onix FTP Transfer"
               style="push"
               tooltip="Onix FTP Transfer">
               <visibleWhen
                  checkEnabled="false">
               <with
                     variable="de.eiswind.mango.client.onix.ftp.cansee">
                  <equals
                        value="true">
                  </equals>
               </with>
            </visibleWhen>
            
         </command>
         
      </menuContribution>
Comment 1 Paul Webster CLA 2011-01-10 12:30:11 EST 
Is this the same problem reported in bug 333792 ?

PW
Comment 2 Remy Suen CLA 2011-08-10 14:02:11 EDT 
Thomas, I cannot seem to reproduce the problem but maybe I am doing something wrong.

Is this still a bug on your side?
Comment 3 Thomas Kratz CLA 2011-08-11 03:08:36 EDT 
Hi Remy, unfortunately I cannot reproduce this anymore.
No trouble on my side as far as I can see.
Comment 4 Remy Suen CLA 2011-08-11 06:15:01 EDT 
(In reply to comment #3)
> Hi Remy, unfortunately I cannot reproduce this anymore.
> No trouble on my side as far as I can see.

Thank you for letting us know, Thomas. Please do not hesitate to reopen the bug or open a new one if you see the problem again.