Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333358 - [formatting] formatting inserts Break in text node even if there is no sibling
Summary: [formatting] formatting inserts Break in text node even if there is no sibling
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.2.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Sarika Sinha CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard: WI65083
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-31 01:28 EST by Sarika Sinha CLA
Modified: 2011-01-12 15:07 EST (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
Patch restricts the addition of break, if text node has no sibling (967 bytes, patch)
2010-12-31 01:30 EST, Sarika Sinha CLA 		no flags Details | Diff
patch (2.20 KB, patch)
2011-01-05 13:21 EST, Nick Sandonato CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2010-12-31 01:28:21 EST 
Build Identifier: M20100909-0800

HTML formatter is inserting a break after the text node even if there is no sibling to the text node. If HedP has a text node with no sibling, no break should be inserted.


Reproducible: Always
Comment 1 Sarika Sinha CLA 2010-12-31 01:30:18 EST 
Created attachment 185922 [details]
Patch restricts the addition of break, if text node has no sibling
Comment 2 Nick Sandonato CLA 2011-01-05 13:21:41 EST 
Created attachment 186107 [details]
patch

Alternative patch.
Comment 3 Nick Sandonato CLA 2011-01-05 13:22:43 EST 
I think the original patch can cause weird formatting like
<p>
  Text</p>

Proposing a patch that will not do that.
Comment 4 Nick Sandonato CLA 2011-01-12 15:07:21 EST 
Code checked in.