Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333315 - Add text to Valgrind view when no errors were found
Summary: Add text to Valgrind view when no errors were found
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Valgrind (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 0.9.0   Edit
Assignee: Elliott Baron CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-29 15:28 EST by Elliott Baron CLA
Modified: 2012-09-28 13:53 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Baron CLA 2010-12-29 15:28:56 EST 
It can be confusing to just present an empty view to the user. We should instead give a message in the Valgrind view stating "No errors found".
Comment 1 Rafael Medeiros Teixeira CLA 2011-08-08 14:17:32 EDT 
I wrote a small patch for this bug. You can check it out at https://github.com/rafaelmt/linuxtools/commit/2b95573dcc7ed638e2515cbabf3fd1972ca34b6a .

Regards
Comment 2 Elliott Baron CLA 2011-08-24 15:38:23 EDT 
Excellent solution! Thanks for the patch.
Comment 3 Rafael Medeiros Teixeira CLA 2011-08-30 09:06:14 EDT 
(In reply to comment #2)
> Excellent solution! Thanks for the patch.

There's a case I missed in the first commit. Please take a look at this further fix:

https://github.com/rafaelmt/linuxtools/commit/31d303df92901c0f6d456ff8f4fa5bb5f07f161a

Regards
Comment 4 Elliott Baron CLA 2011-08-30 18:48:41 EDT 
Thanks for picking up on that Rafael. I've applied your revised patch to Git master.
Comment 5 Wainer dos Santos Moschetta CLA 2011-09-19 10:01:48 EDT 
(In reply to comment #4)
> Thanks for picking up on that Rafael. I've applied your revised patch to Git
> master.

Although target milestone is set to 0.9, will it be available first on 0.8.1?
Comment 6 Andrew Overholt CLA 2011-09-30 16:12:30 EDT 
In general one can trust the Target Milestone :)  In this particular case, the patch was applied only to master and not to stable-0.8 so it was not in 0.8.1.  

As a consumer, if there are specific bug fixes you'd like to see in a particular release, Wainer, I recommend you request such back-ports well before the release deadline so committers can plan accordingly.  I hope this will smooth the process for your consumption in the future.