Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333310 - Wrong character encoding in compare of HistoryView
Summary: Wrong character encoding in compare of HistoryView
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.11   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-29 11:20 EST by Mathias Kinzler CLA
Modified: 2011-06-29 05:15 EDT (History)
5 users (show)

See Also:

Attachments
A patch for this issue. (10.76 KB, application/octet-stream)
2011-02-14 03:09 EST, Kensuke Matsuzaki CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Kinzler CLA 2010-12-29 11:20:15 EST 
The compare editor in the HistoryView seems to use the default encoding instead of the resource encoding. If the project which contains the resource has a different encoding than the workspace, for example, the compare editor will show unreadable characters.
Comment 1 Mathias Kinzler CLA 2010-12-30 07:30:54 EST 
I looked into this in some more detail, and it seems that the place to fix this would be to let BlobStorage implement IEncodedStorage instead of IStorage. But then we need to make sure to somehow propagate the encoding back and forth between the resources in the workspace and the Repository....
Comment 2 Bernard Leach CLA 2011-02-09 00:38:41 EST 
I'm also seeing this problem on Windows platform where the default file encoding in eclipse does not match actual encoding in the file.  I changed the default to match and the two resources had no more differences.
Comment 3 Kensuke Matsuzaki CLA 2011-02-14 03:09:07 EST 
Created attachment 188874 [details]
A patch for this issue.

When right or left of comparing files is real file, use that file's encoding
to decode other hand.
Comment 4 Stefan Lay CLA 2011-06-29 05:15:19 EDT 
Fixed with 17cc1ec58b6c5fa