Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333273 - [Theming] Move all SWT system color definitions to Display
Summary: [Theming] Move all SWT system color definitions to Display
Status: NEW
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 434215 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-12-28 12:19 EST by Ralf Sternberg CLA
Modified: 2014-07-21 08:07 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2010-12-28 12:19:11 EST 
The way SWT system colors are read from the theme is not quite consistent. Some colors have to be defined in the Display element, others on sub-widgets like List-Item or Shell-Titlebar, e.g.:

Display {
  rwt-shadow-color: -> COLOR_WIDGET_NORMAL_SHADOW
  rwt-highlight-color: -> COLOR_WIDGET_HIGHLIGHT_SHADOW
  ...
}

Shell-Titlebar:inactive {
  background-color: -> COLOR_TITLE_INACTIVE_BACKGROUND
  background-gradient-color: -> COLOR_TITLE_INACTIVE_BACKGROUND_GRADIENT
}

As the method getSystemColor() is defined on Display, I think it would be more consistent to let all system colors be defined in the Display element.
Comment 1 Ralf Sternberg CLA 2010-12-28 12:22:32 EST 
This would allow us to deprecate the Shell-Titlebar background-gradient-color, which never had an effect on the title bar gradient, but was only there to define a system property. This property is disturbing anyway, since background gradients can now be defined using background-image.
Comment 2 Ivan Furnadjiev CLA 2014-07-21 08:07:00 EDT 
*** Bug 434215 has been marked as a duplicate of this bug. ***