Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333212 - 'Toggle Comment' doesn't care if there are heading spaces
Summary: 'Toggle Comment' doesn't care if there are heading spaces
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact: Ilina Stefanova CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-26 03:56 EST by Toshihiro Izumi CLA
Modified: 2020-05-14 11:09 EDT (History)
0 users

See Also:

Attachments
patch (2.28 KB, patch)
2010-12-26 22:02 EST, Toshihiro Izumi CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Toshihiro Izumi CLA 2010-12-26 03:56:53 EST 
Toggle Comment(Ctrl+/ or Ctrl+7) doesn't recognize leading spaces.
|<?php
|   // echo 0;
|?>
Move cursor onto the line and hit Ctrl+/.
Line comment will be changed to
| // echo 0;
instead of
|    echo 0;
It indicates 'Toggle Comment' deletes first 2 characters in the line always.
Hit Ctrl+/ again. Line comment will be changed to
|/ echo 0;
and syntax error marker will appear.
Comment 1 Toshihiro Izumi CLA 2010-12-26 22:02:02 EST 
Created attachment 185822 [details]
patch
Comment 2 Zhongwei Zhao CLA 2011-04-14 00:45:53 EDT 
hi Toshihiro,

thanks for your patch,from wtp 3.2.3,we use new toggle comment extension,and the bug does not exist now
Comment 3 Toshihiro Izumi CLA 2011-04-14 08:57:10 EDT 
OK :)

BTW,
Remove Block Comment doesn't work in php part, Toggle Comment/Add Block Comment/Remove Block Comment don't work in html part, on my environment.

EclipseSDK3.7M6
pdt from CVS-HEAD
and other requirements from Indigo repository
Comment 4 Zhongwei Zhao CLA 2011-04-14 22:45:45 EDT 
which version of wtp do you use?
Comment 5 Zhongwei Zhao CLA 2011-04-15 00:44:44 EDT 
yes,you are right,I have tested it,thanks!we will fix it asap!
Comment 6 Zhongwei Zhao CLA 2011-04-27 01:46:39 EDT 
fixed in head
Comment 7 Ilina Stefanova CLA 2011-07-26 02:50:46 EDT 
Verified.