Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333192 - Framework hooks region implementation should fail duplicate bundle installs
Summary: Framework hooks region implementation should fail duplicate bundle installs
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: runtime (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.0.0.M01   Edit
Assignee: Glyn Normington CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 333667
Blocks:
  Show dependency tree
 
Reported: 2010-12-24 07:20 EST by Glyn Normington CLA
Modified: 2011-02-28 10:42 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glyn Normington CLA 2010-12-24 07:20:35 EST 
If a bundle is installed which has the same bundle symbolic name, bundle version, and location as an existing bundle, the existing bundle is returned regardless of which region the bundle resides in. This can be misleading to an application installing a bundle as it can be given a bundle which it cannot use (because the region framework hooks filter out the bundle).

It would be better to fail the install, but this requires a bundle install hook to be implemented in Equinox as detailed in bug 333189.
Comment 1 Glyn Normington CLA 2011-01-10 05:25:24 EST 
Awaiting bundle install hook.
Comment 2 Thomas Watson CLA 2011-01-12 10:14:08 EST 
(In reply to comment #1)
> Awaiting bundle install hook.

I don't think you need an install hook for this.  The fix for bug333667 should solve this problem.
Comment 3 Glyn Normington CLA 2011-01-12 12:04:04 EST 
(In reply to comment #2)
> (In reply to comment #1)
> > Awaiting bundle install hook.
> 
> I don't think you need an install hook for this.  The fix for bug333667 should
> solve this problem.

Yes, you're right! Thanks for pointing this out.

(The bundle install hook is still needed for other reasons though.)
Comment 4 Glyn Normington CLA 2011-02-11 04:19:56 EST 
This was fixed by the upgrade to Equinox 3.7M5.

Note that a bundle install hook appears not to be necessary as we can make do with the bundle event hook.